Price Setting Package 1.1.0

Owned by Ondřej Tesař
Sept 30, 2024
5 min read

Sub-tasks

  • [PFPCS-326] - Merge PriceSettingLevel into CountryInformation

  • [PFPCS-490] - Use Manhattan feature instead of our own implementation for mapping metadata with attribute ids

  • [PFPCS-868] - ConfigUtils.getLookupKeys() should be reworked to use caching - big gain

    • Upgrade note: “INVALID_DIMENSIONS“ - Entry with that error code should be added to WarningConfig

  • [PFPCS-869] - Use closures for CalculatedPrices data initialization - big gain

  • [PFPCS-871] - ActualPriceLookup should be reworked to use caching - big gain

  • [PFPCS-872] - Add batching of competition data lookups - medium gain

  • [PFPCS-873] - Competition lookup is executed twice - medium gain

  • [PFPCS-874] - Country element lookups should be cached - medium gain

  • [PFPCS-937] - PM script testing

  • [PFPCS-1062] - Change names of repositories

Bugs

  • [PFPCS-766] - Fix Reason displayed inside Prices matrix

  • [PFPCS-882] - Product Currency column should be removed from PL/PG

    • Upgrade note: Product Currency column should be manually hidden from PL/PG

  • [PFPCS-982] - Can't get Sales Data from Datamart

  • [PFPCS-983] - Message when SKU is not defined in Source for Anchor

  • [PFPCS-1036] - Incorrect Reason when using Price Exception and Global/Local Manual Override "Yes"

  • [PFPCS-1037] - Issues about chart feature and rounding number on Price Insight Dashboard

  • [PFPCS-1038] - TransactionData do not work after changing name of the element from Configuration to ConfigManager

  • [PFPCS-1083] - Misleading counter on warnings manager

  • [PFPCS-1107] - Make changes in code appropriate to new name of element of PopUpData , RawPrices

  • [PFPCS-1125] - Missing COUNTRY_INFORMATION_CONFIG key in ConfigManager

  • [PFPCS-1133] - Issue UNEXPECTED_ERROR LookupKeys

  • [PFPCS-1134] - We cannot use custom calculation engines anymore

  • [PFPCS-1150] - Unexpected Error about ForecastData displays in Warnings matrix

  • [PFPCS-1155] - Incorrect FinalListPrice when setting "ExceptionTable" in Global/Local Manual Override Allowance

  • [PFPCS-1163] - Change config of PX List Prices

  • [PFPCS-1164] - Can't get Global Price and Global Decision from GlobalLPG

  • [PFPCS-1167] - Exception not caught in warning manager

    • Upgrade note: “NO_EXCEPTION_CONFIG” - Entry with that error code should be added to WarningConfig

  • [PFPCS-1171] - Unexpected Error about ActualPriceLookup appears after full recalculation but disappears after recalculating inside LPG

  • [PFPCS-1172] - Can't get Forecast Data from Datamart

  • [PFPCS-1192] - Should throw warning message when Actual List Price is null in PX List Prices

    • Upgrade note: “NO_ACTUAL_LIST_PRICE“ - Entry with that error code should be added to WarningConfig

  • [PFPCS-1193] - Issue with Price Insight Dashboard after some changes in ConfigManager

  • [PFPCS-1195] - TransactionData cannot be read, unexpected error occurs

  • [PFPCS-1201] - Should change the Reason of Competition strategy that is displayed in Prices matrix when no Competition Data

  • [PFPCS-1226] - Misleading message in lookupEngine error

  • [PFPCS-1242] - Fix error handling while loading exceptions data from price parameter

  • [PFPCS-1249] - AdditionalCalculatorParameters should not be visible

  • [PFPCS-1251] - Fix country mapping in PriceException

  • [PFPCS-1252] - Incorrect Kit price and Anchor price when using PriceSetting Level "Gross"

  • [PFPCS-1257] - Unexpected Error displays when PPStrategySelection is not presented

    • Upgrade note: There was error in WarningConfig, there was two same error codes, called ERROR_LOOKING_UP_STRATEGIES, one of them should be renamed to ERROR_LOOKING_UP_PRICE_STRATEGIES

  • [PFPCS-1263] - Error occur when choosing Price Insights Dashboard

  • [PFPCS-1269] - Price strategy that has value as 0 is ignored when type of Manual Override Allowance is "No"

  • [PFPCS-1271] - Manual Price Reason is not displayed when using Price exception with type of Manual Override Allowance is "Yes"

    • Behaviour of exceptions and column names has been changes. We strongly suggest to create new PL/PG instead of recalculating old ones

    • Upgrade note: “NO_INPUT_FOR_MANUAL_PRICE” - Entry with that error code should be removed from WarningConfig

  • [PFPCS-1275] - Incorrect Price Decision in case Strategy Exception is ignored

  • [PFPCS-1278] - Incorrect warning message displays when Price Override is not allowed

  • [PFPCS-1280] - Fix warning message about Override Remover

    • Upgrade note: “NO_INPUT_FOR_OVERRIDE_REMOVER” - Entry with that error code should be added to WarningConfig

  • [PFPCS-1288] - Should throw warning for Margin when FinalPrice is null or FinalPrice is 0

  • [PFPCS-1291] - Missing warning message when Min Margin is null

  • [PFPCS-1328] - Fix Kit Engine error message when Sub-component or Raw Material is null

  • [PFPCS-1330] - PriceSelector should be hidden when Manual Override Allowance is "No" or "ExceptionTable"

  • [PFPCS-1337] - Fix Exceptions Manager

  • [PFPCS-1341] - HQ LPG should get the warning message that is defined for Country

    • Upgrade note: Manual entries in WarningConfig are working fine for global country now. It can change behaviour, as previously it was ignored

  • [PFPCS-1365] - When Discount % is null then if FinalListPrice = 0 it will not be used in other calculations

  • [PFPCS-1369] - Non consistent preferences

  • [PFPCS-1428] - Country should be mandatory field, not just throw exception when it's null

    • Country for CountryPriceListLogic is mandatory field now, calculation won’t be saved without filling that value

Tasks

  • [PFPCS-812] - Change names of configs about price/strategy overrides

    • Upgrade note: In PP PriceSettingConfig:

      • Keys with “Global Manual Override” should be renamed to: “Global Manual Override Allowance”

      • Keys with “Local Manual Override” should be renamed to: “Local Manual Override Allowance”

  • [PFPCS-813] - Change globalOrientation Configs

  • [PFPCS-817] - Remove "Product" prefix from BPB PXes

  • [PFPCS-884] - Verify quality of Preferences and Labels on clean deployment

    • Upgrade note: Multiple labels and preferences has been changed. Each config should be revised if it is displayed properly

  • [PFPCS-885] - Move TransactionDataUtil from lib to Common

  • [PFPCS-900] - Change naming of lookupKeys

  • [PFPCS-904] - Remove getLookupKeys method from configManager

  • [PFPCS-933] - Remove SKU from Anchor engine config, and change engine code according to that

  • [PFPCS-980] - Change manager calls to be less repetitive/more informative in Price Builder

  • [PFPCS-996] - Prepare logics to work with debugger

  • [PFPCS-1008] - Do not return transaction data and forecast data as element result

  • [PFPCS-1010] - Maintain not crashing debugger for BPB v1.1

  • [PFPCS-1039] - Change placement of the method

  • [PFPCS-1060] - Add groovydoc to utility elements

  • [PFPCS-1073] - Fix Sonar bugs and smells for Price Builder Accelerator

  • [PFPCS-1082] - Remove fork of Shared lib from Library

    • Upgrade note: Most recent SharedLib should be deployed

  • [PFPCS-1089] - Move exchange rates element out of Library

  • [PFPCS-1090] - Add better separation for external inputs to PriceCalculator

    • Upgrade note: Implementation of custom engines has been changed, new parameters for Calculator Engines should be added from scratch.

  • [PFPCS-1093] - Remove existing PriceLevel config from PriceSettingConfig

    • Upgrade note: In PP PriceSettingConfig, key2 for “Global Price” entry should be renamed to “*”

  • [PFPCS-1106] - NetPriceLevel should use ConfigManager and return boolean value

  • [PFPCS-1127] - Unify usage of const config in config manager

  • [PFPCS-1140] - Clean up exception and override handling

  • [PFPCS-1158] - Failing TDD4C after manual conflict resolution

  • [PFPCS-1166] - Unify names of fields in const config

Improvements

  • [PFPCS-1385] - Make Country mandatory for Country Price List Logic