Price Setting Package 1.4.0

Owned by Ondřej Tesař
Sept 30, 2024
6 min read

Sub-tasks

  • [PFPCS-1600] - Split PriceSettingConfig into multiple tables

  • [PFPCS-1601] - Split CountryMappingConfig into multiple tables

  • [PFPCS-1993] - Convert data from different currencies - Actual Price

  • [PFPCS-1994] - Convert data from different currencies - Transaction Data - Datamart / Datasource

  • [PFPCS-1995] - Convert data from different currencies - Cost

  • [PFPCS-2086] - Convert data from different currencies - Transaction Data - PX

Bugs

  • [PFPCS-1604] - Unexpected Error RawMinimumMargin when input wrong type of number into PP MinMargin

  • [PFPCS-2003] - Lack of consistency in new Dependency(Level)Mapping

    • Upgrade notes:

      • Changed keys in DependencyMappingConfig PP

        • Suffix “ Dependency Mapping“ has been removed (e.g. “Transaction Dependency Mapping” → “Transaction”

      • Changed keys in WarningConfig PP

        • DEPENDENCY_ADJUSTMENT_IS_ZERO → DEPENDENCY_LEVEL_ADJUSTMENT_IS_ZERO

        • ERROR_LOOKING_UP_DEPENDENCY_ADJUSTMENT → ERROR_LOOKING_UP_DEPENDENCY_LEVEL_ADJUSTMENT

        • NO_DEPENDENCY_ADJUSTMENT → NO_DEPENDENCY_LEVEL_ADJUSTMENT

        • INVALID_DEPENDENCY_TABLE_ID → INVALID_DEPENDENCY_LEVEL_TABLE_ID

  • [PFPCS-2004] - No FinalPrice on Independent PLI not handled in Dependent PLI

  • [PFPCS-2005] - Change name of key3 in RoundingRulesConfig for Country or CountryName

    • Upgrade notes:

      • Changes in RoundingRulesConfig PP:

        • remove label (verify only - should be autodeployed)

        • key3, rename "DependencyMapping" -> "DependencyLevelName"

        • key3, changed translation (label) "Dependency Mapping" -> "Dependency Level Name"

      • DependencyMappingConfig PP (only when using sample data from standard configuration)

        • Actual Price, attr1: "Name" -> "DependencyLevelName"

        • Actual Price, attr3: "Country" -> "DependencyLevelName"

        • Cost, attr1: "Name" -> "DependencyLevelName"

        • Cost, attr3: "Country" -> "DependencyLevelName"

        • Discount Group, attr1: "SalesOrg" -> "DependencyLevelName"

        • Discount Group, attr3: "Country" -> "DependencyLevelName"

        • Price Exception, attr1: "Name" -> "-ADJUSTME-" (Default table does not support dependency mapping)

        • Price Exception, attr3: "Country" -> "-ADJUSTME-" (Default table does not support dependency mapping)

        • Forecast, attr3: "Country " -> "-ADJUSTME" (We don't have a default table for forecasts)

        • Strategy Exception, attr1: "Name" -> "-ADJUSTME-" (Default table does not support dependency mapping)

        • Strategy Exception, attr3: "Country" -> "-ADJUSTME-" (Default table does not support dependency mapping)

        • Forecast, attr3: "Country " -> "-ADJUSTME" (We don't have a default table for transactions)

        • Product Competition, attr3: "country" -> "ADJUSTME-" (We don't have a default configuration for this)

        • Rounding, attr3: "DependencyMapping" -> "DependencyLevelName"

  • [PFPCS-2006] - Wrong config aborts calculation instead of just rounding module

  • [PFPCS-2007] - Remove NO_ROUNDING_RULE warning when price is null

  • [PFPCS-2008] - Standard config should have different values for rounding rule

  • [PFPCS-2013] - Investigate standard config for actualListPrice

  • [PFPCS-2014] - Fix standard config in dependencyMappingConfig

  • [PFPCS-2016] - Autodeploy does not change column names of PX

  • [PFPCS-2017] - Volume breakdowns probably do not work when deploying by PM

  • [PFPCS-2018] - Logic to bootstrap parameters won't work properly if there is already parameter with same name and other target date

  • [PFPCS-2024] - Strategy with negative result is ignored in Independent PG

  • [PFPCS-2026] - Issue when removing duplicates after loading base and standard strategies

  • [PFPCS-2027] - Calculation aborted if there is no Currency Conversion

  • [PFPCS-2029] - Cost in Independent PG is not affected by different Currency

  • [PFPCS-2048] - Hide MinimumMarginPrice warning message when Price Checks module is turned off

  • [PFPCS-2055] - Actual Price - Unexpected Error displays when optional column Currency is missing

  • [PFPCS-2056] - Lookup ActualPrice from PL - Unexpected Error displays when resultPrice is null

  • [PFPCS-2061] - Actual List Price in Dependent PG should lookup resultPrice from Dependent PL

  • [PFPCS-2090] - PP LookupEngineConfig doesn't allow to have same SKU but with different DependencyLevelName

  • [PFPCS-2092] - Incorrect results return from strategies that are using LookupEngine in DependencyPG

  • [PFPCS-2096] - Table dependency mapping do not work on PX lookups which don't utilize "includeEmptyFallback" flag

  • [PFPCS-2097] - Table cost lookup does not work

  • [PFPCS-2102] - Exceptions do not work with validity period filtering

  • [PFPCS-2103] - CalculatedPrices have error in Dependent PG when Independent Level Price is null

  • [PFPCS-2108] - Misleading label in PriceSettingDimensions

  • [PFPCS-2109] - PLApprovalWorkflow: Execution of ApprovalWorkflow[WorkflowUtils] timed out after 5 units

  • [PFPCS-2112] - Incorrect Actual Price is returned in Dependent PG when looking up from PL

  • [PFPCS-2113] - Actual Price is looking up from PL without converting Currency

  • [PFPCS-2114] - Wrong parameters passed to buildUpToDateFilter()

  • [PFPCS-2115] - CalculatedPrices errror when Advanced Cost module is turned off

  • [PFPCS-2116] - Unable to save ValidFrom/ValidTo in Discount Group PX

  • [PFPCS-2117] - Price Exception - Message is not thrown when validity periods of a product are overlapped

  • [PFPCS-2118] - AdvancedCost - Unexpected Error Cannot invoke method collectEntries() on null object

  • [PFPCS-2120] - Incorrect name of Arithmetic function is using for Advanced Cost - Simple instead of Single

  • [PFPCS-2121] - It should throw warning message when no Cost is presented when using Advanced Cost

  • [PFPCS-2122] - Change Valid Until to Valid To for all configurable PP/PX lookups

  • [PFPCS-2125] - Can't calculate Advanced Cost properly using arithmetic Avg

  • [PFPCS-2128] - AvgCost and SumCost should be calculated correctly when setting cost look up with only validFrom

  • [PFPCS-2137] - AdvancedCost - Cost cannot be retrieved when AdvancedCost module is off

  • [PFPCS-2145] - Valid From and Valid To are not working properly when looking up Exceptions from PP

  • [PFPCS-2152] - Discount Group returns null when Valid From and Valid To are not configured in PP PriceSettingConfig

  • [PFPCS-2153] - Cannot get property 'PARAM' on null object after PFPCS-2003 was merged

  • [PFPCS-2157] - AdvancedCost - Unexpected Error Cannot invoke method collectEntries() on null object when there is no CostSelection user config

  • [PFPCS-2164] - Missing ValidFrom/ValidTo feature for PP RoundingRulesConfig lookup

  • [PFPCS-2166] - Pricelist: Margin% not taking into account manual override

  • [PFPCS-2168] - Some Unexpected Error are displaying after KPI Check was merged

  • [PFPCS-2176] - Stock - UNEXPECTED_ERROR: Unable to convert value [] of type java.lang.String to type net.pricefx.domain.MatrixLookupTableValue3Key

  • [PFPCS-2189] - Rounding issue - Calculation Price in Prices matrix should be changed

  • [PFPCS-2190] - PriceInsightsDashboard does not have updated lib reference

  • [PFPCS-2191] - Add standard configuration for days of cover and adjust it

  • [PFPCS-2196] - Transaction Data from DM/DS should apply exchange rates differently

  • [PFPCS-2199] - Incorrect type of avgVolumePerDay is using can lead to incorrect Stock Cover Days

  • [PFPCS-2201] - Fix Format Type of Stock and Stock Cover Days

  • [PFPCS-2202] - Add warning message when Stock / Stock Cover Days null

  • [PFPCS-2211] - Error displays when Discount Groups is null

  • [PFPCS-2213] - It should ignore the row that has empty DependencyLevelName when looking up Stock data

  • [PFPCS-2214] - StockCoverDays can't display value 0

  • [PFPCS-2217] - Enhance technical message if there is NO_SUITABLE_ROUNDING_RESULT

  • [PFPCS-2218] - Fix small bugs about Labels

  • [PFPCS-2222] - Errors about InputDependencyUtil and PriceParameterUtil

  • [PFPCS-2228] - CalculatedPrices - Unexpected Error about RoundingRules displays

  • [PFPCS-2231] - PriceInsightsDashboard can't display properly

  • [PFPCS-2239] - Can't display Cost value if it equals 0

  • [PFPCS-2240] - Missing data file for CostTypeDefinitions PP

  • [PFPCS-2241] - Missing data file for StockData PP

Stories

  • [PFPCS-680] - Convert data from different currencies

  • [PFPCS-1690] - Price check - Recommended Retail Price

  • [PFPCS-1691] - KPI Check - Days of Cover

    • Upgrade notes:

      • New entry in PriceSettingConfig:

        • Key: Stock

        • Condition: * / Independent / Dependent

        • Type: Lookup

        • Source: PX / PP

        • Source Table: name of the table holding data

        • Source Field: name of the column holding stock value

        • Source Field 2 (attribute5): name of the valid from date column. Optional.

        • Source Field 3 (attribute6): name of the valid to the date column. Optional.

      • New entry in DependencyMappingConfig

        • Name: Stock

        • Dependency Field: name of the column in Dependency Configuration PP contains the value to be compared

        • Type: Lookup / Table

        • Mapping Source Field: name of the column in the source table contains the value to be compared

      • New entries in WarningConfig:

        • UNSUPPORTED_STOCK_DATA_SOURCE_TYPE

        • UNABLE_TO_READ_STOCK_TABLE

        • NO_STOCK_DATA

        • NO_INPUT_FOR_STOCK_COVER_DAYS

    • Sample table for data is at the bottom of this page

  • [PFPCS-1904] - Multiple lookup sources for Cost data

    • Upgrade notes:

      • New module. To turn it on, add a new AP entry

        • key: PSP_ADVANCED_COST

        • value: true

      • New Price Parameter CostTypeDefinition. Attributes:

        • name: CostType

        • attribute1: CalculationEngineSuffix

        • attribute2: Type

        • attribute3: CalculationMethod

        • attribute4: SourceTable

        • attribute5: SourceField

        • attribute6: ValidFrom

        • attribute7: ValidTo

        • attribute8: DependencyField

        • attribute9: DependencyType

        • attribute10: MappingSourceField

        • attribute11: Currency

      • New Price Parameter, CostSelection. Attributes:

        • keys are dimensions

        • attribute1: Cost Type #1

        • attribute2: Cost Type #2

        • attribute3: Cost Type #3

        • attribute4: Cost Type #3

        • attribute5: Cost Type #5

      • New entries in WarningConfig:

        • ERROR_PARSING_COST_DEFINITION

        • ERROR_CALCULATING_COST

        • ERROR_LOOKING_UP_COST_SELECTION_CONFIG

    • Already deployed ProductCosts might be used as a data table

Tasks

  • [PFPCS-2015] - Enhance technical message in warning about no rounding rules

  • [PFPCS-2110] - Write guide to PM deployment

  • [PFPCS-2198] - Create autopublishing configuration for PSP

  • [PFPCS-2219] - Groovy check instead of null check in rounding utils

Improvements

  • [PFPCS-989] - BPB should be configured Valid From/ ValidTo same with PLCM

    • Upgrade notes:

      • Add ValidFromField and ValidToField configuration in PriceSettingConfig (optional):

        • Actual Price (only works for PX)

        • Cost (“ValidFrom” to attribute6 and “ValidTo” to attribute7)

        • Discount Group

        • Price Exception - Independent

        • Price Exception - Dependent

        • Strategy Exception - Independent

        • Strategy Exception - Dependent

      • In corresponding PP and PX tables fill fields pointed in PriceSettingConfig

        • Those fields should be key(PP)/business key(PX). It is not technical requirement for that but it will be impossible to pass additional parameters otherwise.

      • Changes in WarningConfig:

        • PX_VALIDITY_PERIODS_OVERLAPPED

        • PP_VALIDITY_PERIODS_OVERLAPPED

        • DISCOUNT_GROUP_FALLBACK_APPLIED

        • FIELD_NOT_FOUND

    • This feature is optional, every old table will be working. No new table is needed.